And it’s been eight days since we learned 0.19.1 didn’t fix the problem. There’s a lesson to be learned here: don’t push a massive update close to the holidays because, ya know, you might break federation and go on vacation for a week.

  • Adam@doomscroll.n8e.dev
    link
    fedilink
    English
    arrow-up
    0
    ·
    2 years ago

    There’s a lesson to be learned here: don’t push a massive update close to the holidays because, ya know, you might break federation and go on vacation for a week.

    I mean, no one has forced any admins to deploy a new version. But yeah, this is an annoying one.

  • hydroptic@sopuli.xyz
    link
    fedilink
    English
    arrow-up
    0
    ·
    2 years ago

    There’s a lesson to be learned here

    The lesson is don’t trust a fucking tankie to be able to run a development project

    • Hjalmar@feddit.nu
      link
      fedilink
      English
      arrow-up
      0
      ·
      2 years ago

      Well then, take your beloved capitalism and get the hell out of here. There are lots of profit driven social media platforms that you could try out.

    • 1984@lemmy.today
      link
      fedilink
      English
      arrow-up
      0
      ·
      edit-2
      2 years ago

      That’s ridiculous and you are letting your brain get clouded by your political views.

    • maegul (he/they)@lemmy.ml
      link
      fedilink
      English
      arrow-up
      0
      ·
      2 years ago

      In my experience the worst thing about tankies is all the loud anti-tankie noise they attract like this comment.

      I’m not one myself, but venom like this very much outweighs anything I’ve found untoward from any tankie here.

    • andrew_bidlaw@sh.itjust.works
      link
      fedilink
      English
      arrow-up
      0
      ·
      2 years ago

      I don’t think any political stance can guarantee that one would (not) make a fuck up at any given time. The shit they do is lit, it lets me consume that post and then answer you, us being from different volunteer-run instances. Give these guys some credit. At least, they put their code where their mouth is and let us all use it.

      In the language of 1900’s socialists, I can’t care whose gold in a cart that is, if I can appropriate it to serve our means.

      If that’s not the case, we all can fork it. But I doubt you or I have enough spite to compete with them and continuously support it. With all problems, if they haven’t started their project, we couldn’t have these nice places, so even though I disagree with them, I can’t really devalue the labor they put in there, for everyone’s pleasure.

    • syd@lemy.lol
      link
      fedilink
      English
      arrow-up
      0
      ·
      2 years ago

      If you don’t like their way of developing, then do it yourself, cunt.

      • hydroptic@sopuli.xyz
        link
        fedilink
        English
        arrow-up
        0
        ·
        edit-2
        2 years ago

        Remember this comment the next time you say you dislike a movie, book, game or food. If you don’t like it, do it yourself cunt, criticism is not allowed unless you do it yourself

        • syd@lemy.lol
          link
          fedilink
          English
          arrow-up
          0
          ·
          edit-2
          2 years ago

          If I dislike a movie, book, game or food; I would criticise the movie, book, game or food and not the director’s, writer’s, developer’s or chef’s political views.

          Don’t get me wrong, I’m not saying don’t criticise their political views. I’m saying don’t criticise the product because of their political views.

    • mosiacmango@lemm.ee
      link
      fedilink
      English
      arrow-up
      0
      ·
      edit-2
      2 years ago

      Youre on that tankies platform right now, bro.

      You love tankies or something? Using tankie-ware like you are?

  • vojel@discuss.tchncs.de
    link
    fedilink
    English
    arrow-up
    0
    ·
    2 years ago

    I am confused but it seems most other instances besides feddit.de works quite well. I moved my account because the federation on feddit was (is?) broken. But yeah this was a major change and I guess most instances are sidecar projects and not professionally hosted nor maintained. I would definitely pay for a proper hosted and maintained Lemmy instance.

  • Chr0nos1@lemmy.world
    link
    fedilink
    English
    arrow-up
    0
    ·
    2 years ago

    It’s been one week since you looked at me Cocked your head to the side and said, “I’m angry”

    • Illecors@lemmy.cafe
      link
      fedilink
      English
      arrow-up
      0
      ·
      2 years ago

      That fix is for another issue. I’ve had to do it once already, other admins - twice. It’s a bug since at least 0.18.4

  • rglullis@communick.news
    link
    fedilink
    English
    arrow-up
    0
    ·
    2 years ago

    There is also a lesson in implementing proper tests. During these holidays I started to play a bit more with Rust and went on to look at Lemmy’s backend code. Not a single unit test in sight…

    • Spuddlesv2@lemmy.ca
      link
      fedilink
      English
      arrow-up
      0
      ·
      2 years ago

      We all await your commit containing all those simple unit tests with bated breath.

      • rglullis@communick.news
        link
        fedilink
        English
        arrow-up
        0
        ·
        2 years ago

        I want to work an issue that is open since 2020, but I can only justify dropping all my other work for that if I have enough paying customers interested in some new feature. So, help me get 50 customers to my “all in one” hosting service and I will start dedicate a week to it, which should be more than enough time for even a Rust newbie like me to submit a proper PR to that issue. Ok?

        • spiderman@ani.social
          link
          fedilink
          English
          arrow-up
          0
          ·
          2 years ago

          This issue looked interesting to me but I know I simply can’t submit a pr with chatgpt generated code. For a project this big, extensive testing should be done. I don’t know how extensive testing is done in lemmy but if it isn’t proper, they should do it before it becomes a mess.

        • Nutomic@lemmy.ml
          link
          fedilink
          English
          arrow-up
          0
          ·
          2 years ago

          There is already an open PR for Oauth, though Im not sure whats the difference to LDAP. Regarding tests you must have looked in the wrong place, we have a couple hundred already. Docs are here.

          • rglullis@communick.news
            link
            fedilink
            English
            arrow-up
            0
            ·
            edit-2
            2 years ago

            Unless there is some thing inherent to how Rust runs tests, the test script seems be mostly integration tests exercising the API. There does not seem to be unit tests which would be the first thing you’d need to have to test like the function that seems to be the source of the bug. (Hint, if your test suite needs to have a running db, you are not unit testing.)

            As for OAuth vs LDAP: both could be used as part of a Single Sign-On solution, but the actual use cases are completely different. Having LDAP authentication would allow, e.g., to let users authenticate to Lemmy using an intranet account or (in the case of Communick) customers could use the same credentials for their Mastodon or Matrix accounts.

            • Nutomic@lemmy.ml
              link
              fedilink
              English
              arrow-up
              0
              ·
              2 years ago

              Sounds like you are looking at the api tests then. There are also unit tests which you can run with ./scripts/test.sh. The database is a fundamental part of Lemmy, so its obviously required for many of the unit tests. It may be possible to mock the db, but that would be a lot of effort for very little benefit, and might even introduce additional bugs.